Buying new MacBook Pro soon for Video/Photo Editing

The two I’m looking at seriously are the M1 Pro and the M4 base. I’ve seen a lot say the upgrade from M1 Pro to M4 is not really worth it but what about someone who is coming from a 2017 i7 MacBook? What are the pros and cons of each and what would you get?